Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559422

Re: [PATCH] virtio_console: fix a crash in config_work_handler

Show all headers | View raw

On (Sat) 14 Jan 2017 [11:38:39], G. Campana wrote:
> Using control_work instead of config_work as the 3rd argument to
> container_of results in an invalid portdev pointer. Indeed, the work
> structure is initialized as below:
> 
>     INIT_WORK(&portdev->config_work, &config_work_handler);
> 
> It leads to a crash when portdev->vdev is dereferenced later. This bug
> is triggered when the guest uses a virtio-console without multiport
> feature and receives a config_changed virtio interrupt.

Thanks, the patch is fine, but needs signed-off-by.

Please also post to virtualization@lists.linux-foundation.org


		Amit

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] virtio_console: fix a crash in config_work_handler "G. Campana" <gcampana@quarkslab.com> - 2017-01-14 12:00 +0100
  Re: [PATCH] virtio_console: fix a crash in config_work_handler Amit Shah <amit.shah@redhat.com> - 2017-01-16 04:40 +0100
    [PATCH v2] virtio_console: fix a crash in config_work_handler "G. Campana" <gcampana@quarkslab.com> - 2017-01-16 10:50 +0100
      Re: [PATCH v2] virtio_console: fix a crash in config_work_handler Amit Shah <amit.shah@redhat.com> - 2017-01-16 11:30 +0100
        Re: [PATCH v2] virtio_console: fix a crash in config_work_handler "Michael S. Tsirkin" <mst@redhat.com> - 2017-01-16 14:40 +0100

csiph-web