Re: [PATCH v2] virtio_console: fix a crash in config_work_handler

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] virtio_console: fix a crash in config_work_handler
Date	2017-01-16 14:40 +0100
Message-ID	<t0fFU-10y-7@gated-at.bofh.it> (permalink)
References	<t06jf-2Xg-9@gated-at.bofh.it> <t0c5j-6Xo-13@gated-at.bofh.it> <t0cI2-7wv-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 16, 2017 at 03:57:23PM +0530, Amit Shah wrote:
> On (Mon) 16 Jan 2017 [10:45:02], G. Campana wrote:
> > Using control_work instead of config_work as the 3rd argument to
> > container_of results in an invalid portdev pointer. Indeed, the work
> > structure is initialized as below:
> > 
> >     INIT_WORK(&portdev->config_work, &config_work_handler);
> > 
> > It leads to a crash when portdev->vdev is dereferenced later. This bug
> > is triggered when the guest uses a virtio-console without multiport
> > feature and receives a config_changed virtio interrupt.
> > 
> > Signed-off-by: G. Campana <gcampana@quarkslab.com>
> 
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
> 
> Michael, can you please pick this up?
> 
> 		Amit

Sure.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] virtio_console: fix a crash in config_work_handler "G. Campana" <gcampana@quarkslab.com> - 2017-01-14 12:00 +0100
  Re: [PATCH] virtio_console: fix a crash in config_work_handler Amit Shah <amit.shah@redhat.com> - 2017-01-16 04:40 +0100
    [PATCH v2] virtio_console: fix a crash in config_work_handler "G. Campana" <gcampana@quarkslab.com> - 2017-01-16 10:50 +0100
      Re: [PATCH v2] virtio_console: fix a crash in config_work_handler Amit Shah <amit.shah@redhat.com> - 2017-01-16 11:30 +0100
        Re: [PATCH v2] virtio_console: fix a crash in config_work_handler "Michael S. Tsirkin" <mst@redhat.com> - 2017-01-16 14:40 +0100

csiph-web