Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1514035

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

Show all headers | View raw

On Wed, Nov 02, 2016 at 08:18:51PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/02/2016 08:08 PM, Jon Mason wrote:
> 
> >Clean-up the documentation to the bgmac-amac driver, per suggestion by
> >Rob Herring, and add details for NS2 support.
> >
> >Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> >---
> > Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++++++++++-----
> > 1 file changed, 11 insertions(+), 5 deletions(-)
> >
> >diff --git a/Documentation/devicetree/bindings/net/brcm,amac.txt b/Documentation/devicetree/bindings/net/brcm,amac.txt
> >index ba5ecc1..2fefa1a 100644
> >--- a/Documentation/devicetree/bindings/net/brcm,amac.txt
> >+++ b/Documentation/devicetree/bindings/net/brcm,amac.txt
> >@@ -2,11 +2,17 @@ Broadcom AMAC Ethernet Controller Device Tree Bindings
> > -------------------------------------------------------------
> >
> > Required properties:
> >- - compatible:	"brcm,amac" or "brcm,nsp-amac"
> >- - reg:		Address and length of the GMAC registers,
> >-		Address and length of the GMAC IDM registers
> >- - reg-names:	Names of the registers.  Must have both "amac_base" and
> >-		"idm_base"
> >+ - compatible:	"brcm,amac"
> >+		"brcm,nsp-amac"
> >+		"brcm,ns2-amac"
> >+ - reg:		Address and length of the register set for the device. It
> >+		contains the information of registers in the same order as
> >+		described by reg-names
> >+ - reg-names:	Names of the registers.
> >+		"amac_base":	Address and length of the GMAC registers
> >+		"idm_base":	Address and length of the GMAC IDM registers
> >+		"nicpm_base":	Address and length of the NIC Port Manager
> >+				registers (required for Northstar2)
> 
>   Why this "_base" suffix? It looks redundant...

Yes.  Rob Herring pointed out the same thing.  It is ugly, but follows
the existing binding.

Thanks,
Jon


> 
> [...]
> 
> MBR, Sergei
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/7] add NS2 support to bgmac Jon Mason <jon.mason@broadcom.com> - 2016-11-02 18:10 +0100
  [PATCH v5 1/7] net: phy: broadcom: add bcm54xx_auxctl_read Jon Mason <jon.mason@broadcom.com> - 2016-11-02 18:10 +0100
    Re: [PATCH v5 1/7] net: phy: broadcom: add bcm54xx_auxctl_read Florian Fainelli <florian.fainelli@broadcom.com> - 2016-11-02 18:20 +0100
  Re: [PATCH v5 3/7] net: phy: broadcom: Add BCM54810 PHY entry Florian Fainelli <florian.fainelli@broadcom.com> - 2016-11-02 18:20 +0100
  [PATCH v5 3/7] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-11-02 18:20 +0100
    Re: [PATCH v5 3/7] net: phy: broadcom: Add BCM54810 PHY entry Andrew Lunn <andrew@lunn.ch> - 2016-11-02 19:40 +0100
  Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings  to amac Florian Fainelli <f.fainelli@gmail.com> - 2016-11-02 18:20 +0100
  [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac Jon Mason <jon.mason@broadcom.com> - 2016-11-02 18:20 +0100
    Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings  to amac Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-11-02 18:20 +0100
      Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings  to amac Jon Mason <jon.mason@broadcom.com> - 2016-11-02 18:30 +0100
        Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings  to amac Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-11-02 21:00 +0100
  [PATCH v5 5/7] net: ethernet: bgmac: device tree phy enablement Jon Mason <jon.mason@broadcom.com> - 2016-11-02 18:20 +0100
    Re: [PATCH v5 5/7] net: ethernet: bgmac: device tree phy enablement Rafal Milecki <rafal@milecki.pl> - 2016-11-03 09:50 +0100
      Re: [PATCH v5 5/7] net: ethernet: bgmac: device tree phy enablement Jon Mason <jon.mason@broadcom.com> - 2016-11-03 17:50 +0100
  Re: [PATCH v5 0/7] add NS2 support to bgmac David Miller <davem@davemloft.net> - 2016-11-03 21:10 +0100

csiph-web