Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry

From	Jon Mason <jon.mason@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry
Date	2016-11-01 21:10 +0100
Message-ID	<syNxF-4RO-63@gated-at.bofh.it> (permalink)
References	<syLvP-3jQ-5@gated-at.bofh.it> <syLvP-3jQ-7@gated-at.bofh.it> <syMie-3SW-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote:
> Hi Jon
> 
> > @@ -56,6 +57,8 @@
> >  #define PHY_BRCM_EXT_IBND_TX_ENABLE	0x00002000
> >  #define PHY_BRCM_CLEAR_RGMII_MODE	0x00004000
> >  #define PHY_BRCM_DIS_TXCRXC_NOENRGY	0x00008000
> > +#define PHY_BRCM_EXP_LANE_SWAP		0x00010000
> > +
> 
> You define this, but don't use it...

Good catch.  Cruft from the last patch.  I'll sendout a quick v4 to
address this and the missing Documentation patch.

> 
>     Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-11-01 19:00 +0100
  Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Andrew Lunn <andrew@lunn.ch> - 2016-11-01 19:50 +0100
    Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-11-01 21:10 +0100

csiph-web