Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1513484

Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry

Path csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Jon Mason <jon.mason@broadcom.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry
Date Tue, 01 Nov 2016 21:10:03 +0100
Message-ID <syNxF-4RO-63@gated-at.bofh.it> (permalink)
References <syLvP-3jQ-5@gated-at.bofh.it> <syLvP-3jQ-7@gated-at.bofh.it> <syMie-3SW-11@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9kSYAkv2IZu2ATuWD7yEbOIfSprtoVZ52cW3grbcAzQ=; b=U1h3kjrFci6ta3qKVy4IjcjqMtFGOFbtHzTdPYZ3mz0iiDDybWfpc8dURZasptuaLR VtQ7/r/H64HLNec/5aUHS0w14DQuOv3utmKi2VdFrJOMNa2vAQBqUOPqCeQORuKyIWyf TEygZD2Zp2ovjeB3M12skWbQWFdPyLOUC3l+o=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9kSYAkv2IZu2ATuWD7yEbOIfSprtoVZ52cW3grbcAzQ=; b=gHvZvF4mfQo3C4RneVfM+VZVW+JtJzT4Snsrj9FIrBd0xF8frpoS4+yaMfJN55Q1Pg /tMfYaHGJUDV4ntU48Yt7j71DTMKc6xEuDY5jMi9YYngq7ztvrSN8Gw/YMRuV6l/bYGl 5jNJ2+5VGgq1AYMJuoknLzvtkjPIAA4S231XR2FeNkKC1dOWXjnRNwzlKq/wx3a6ZgGk GVWAs2zyrSC65OdiRqN+WXJRljWm4jK98nd0xrOANRQ+yzHPpGWwci6mEqLDiHoKeeru Wjhu5zSykL9zzy1t8kwDcBWYl0v+GOKlQpa7y9sdM5VHyrOiOjpoZrZWpOG/uIhO7p8n f7Ag==
X-Gm-Message-State ABUngvdmqqBO9JbwDkPMfYJGdlSugj+MRqW1Rljc2yv1/ooDihTquUZ6bSfEXZOFKT3UWJi6
X-Received by 10.98.160.29 with SMTP id r29mr19447522pfe.103.1478030397248; Tue, 01 Nov 2016 12:59:57 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.24 (2015-08-30)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 17
Organization linux.* mail to news gateway
X-Original-Cc David Miller <davem@davemloft.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Florian Fainelli <f.fainelli@gmail.com>, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl, linux-arm-kernel@lists.infradead.org
X-Original-Date Tue, 1 Nov 2016 15:59:48 -0400
X-Original-Message-ID <20161101195946.GA26962@broadcom.com>
X-Original-References <1478022694-25308-1-git-send-email-jon.mason@broadcom.com> <1478022694-25308-3-git-send-email-jon.mason@broadcom.com> <20161101184639.GI10785@lunn.ch>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1513484

Show key headers only | View raw


On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote:
> Hi Jon
> 
> > @@ -56,6 +57,8 @@
> >  #define PHY_BRCM_EXT_IBND_TX_ENABLE	0x00002000
> >  #define PHY_BRCM_CLEAR_RGMII_MODE	0x00004000
> >  #define PHY_BRCM_DIS_TXCRXC_NOENRGY	0x00008000
> > +#define PHY_BRCM_EXP_LANE_SWAP		0x00010000
> > +
> 
> You define this, but don't use it...

Good catch.  Cruft from the last patch.  I'll sendout a quick v4 to
address this and the missing Documentation patch.

> 
>     Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-11-01 19:00 +0100
  Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Andrew Lunn <andrew@lunn.ch> - 2016-11-01 19:50 +0100
    Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-11-01 21:10 +0100

csiph-web