Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511423
| From | John Stultz <john.stultz@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes |
| Date | 2016-10-28 23:20 +0200 |
| Message-ID | <sxmJb-5cR-9@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <sxbXr-6vs-11@gated-at.bofh.it> <sxc77-6yE-15@gated-at.bofh.it> <sxcqt-6Y9-17@gated-at.bofh.it> <sxdZf-7Oz-1@gated-at.bofh.it> <sxeBX-8kL-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Oct 28, 2016 at 5:34 AM, Leo Yan <leo.yan@linaro.org> wrote:
> On Fri, Oct 28, 2016 at 08:52:49PM +0900, Jaehoon Chung wrote:
>
> [...]
>
>> >> Could you check the below thing..
>> >>
>> >> /* find reset controller when exist */
>> >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
>> >> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>> >> if (IS_ERR(pdata->rstc)) {
>> >> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>> >> return ERR_PTR(-EPROBE_DEFER);
>> >
>> > Confirmed with this fixing, the kernel can bootup successfully.
>> >
>> > Thanks for this.
>>
>> Thanks for checking this..If this approach is not bad, i will send the patch.
>> Or if there are other good approaches, let me know, plz.
>
> I'd like Guodong and John to confirm for Hikey specific. I have no
> knowledge for this so cannot answer.
No objection from me. I hadn't run into the issue, as I'm not booting
off the sd card.
The patch from Jaehoon doesn't seem to cause trouble in my testing so
far, so I think its worth generating a patch and sending it in for
4.9-rc
thanks
-john
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Vincent Guittot <vincent.guittot@linaro.org> - 2016-10-27 16:00 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes John Stultz <john.stultz@linaro.org> - 2016-10-27 22:30 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 09:30 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 09:40 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 11:50 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 12:00 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 12:20 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 14:00 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 14:40 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes John Stultz <john.stultz@linaro.org> - 2016-10-28 23:20 +0200
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 10:10 +0200
csiph-web