Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

From	Jaehoon Chung <jh80.chung@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date	2016-10-28 14:00 +0200
Message-ID	<sxdZf-7Oz-1@gated-at.bofh.it> (permalink)
References	(6 earlier) <sx9VE-5fQ-45@gated-at.bofh.it> <sx9VE-5fQ-41@gated-at.bofh.it> <sxbXr-6vs-11@gated-at.bofh.it> <sxc77-6yE-15@gated-at.bofh.it> <sxcqt-6Y9-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 10/28/2016 07:19 PM, Leo Yan wrote:
> On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:
> 
> [...]
> 
>>>>> Could you share the log? Is there any log about failure?
>>>>
>>>> Sure, please see below log:
>>>
>>> It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
>>> Maybe hi6220 has handled the reset controller(?)...
>>>
>>> I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER..
>>
>> Could you check the below thing..
>>
>>         /* find reset controller when exist */
>> -       pdata->rstc = devm_reset_control_get_optional(dev, NULL);
>> +       pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>>         if (IS_ERR(pdata->rstc)) {
>>                 if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>>                         return ERR_PTR(-EPROBE_DEFER);
> 
> Confirmed with this fixing, the kernel can bootup successfully.
> 
> Thanks for this.

Thanks for checking this..If this approach is not bad, i will send the patch.
Or if there are other good approaches, let me know, plz.

Best Regards,
Jaehoon Chung

> 
>> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller?
>>
>>
>> Best Regards,
>> Jaehoon Chung
> 
> 
>

Thread

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Vincent Guittot <vincent.guittot@linaro.org> - 2016-10-27 16:00 +0200
  Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes John Stultz <john.stultz@linaro.org> - 2016-10-27 22:30 +0200
    Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 09:30 +0200
      Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 09:40 +0200
        Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 11:50 +0200
          Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 12:00 +0200
            Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 12:20 +0200
              Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 14:00 +0200
                Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 14:40 +0200
                Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes John Stultz <john.stultz@linaro.org> - 2016-10-28 23:20 +0200
      Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 10:10 +0200

csiph-web