Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1510189

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

From Vincent Guittot <vincent.guittot@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date 2016-10-27 16:00 +0200
Message-ID <swTnS-2Bn-127@gated-at.bofh.it> (permalink)
References <s9UVH-4Gy-15@gated-at.bofh.it> <s9UVH-4Gy-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

My hikey board failed to detect and mount sdcard with v4.9-rc1 and i
have bisected the issue to this patch. Once reverted, the sdcard is
detected again.

Regards,
Vincent

On 25 August 2016 at 05:00, Guodong Xu <guodong.xu@linaro.org> wrote:
> Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220
>
> Code and documentation to this property were confirmed by maintainers.
> See:
> [1] https://patchwork.kernel.org/patch/9276607/
> [2] https://patchwork.kernel.org/patch/8487151/
> [3] https://lkml.org/lkml/2016/8/12/91
>
> cc: Jaehoon Chung <jh80.chung@samsung.com>
> cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index d0b887a..63608e9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -771,6 +771,7 @@
>                         interrupts = <0x0 0x48 0x4>;
>                         clocks = <&sys_ctrl 2>, <&sys_ctrl 1>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>;
>                         bus-width = <0x8>;
>                         vmmc-supply = <&ldo19>;
>                         pinctrl-names = "default";
> @@ -790,6 +791,7 @@
>                         #size-cells = <0x0>;
>                         clocks = <&sys_ctrl 4>, <&sys_ctrl 3>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>;
>                         vqmmc-supply = <&ldo7>;
>                         vmmc-supply = <&ldo10>;
>                         bus-width = <0x4>;
> @@ -807,6 +809,7 @@
>                         interrupts = <0x0 0x4a 0x4>;
>                         clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>;
>                         bus-width = <0x4>;
>                         broken-cd;
>                         pinctrl-names = "default", "idle";
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Vincent Guittot <vincent.guittot@linaro.org> - 2016-10-27 16:00 +0200
  Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes John Stultz <john.stultz@linaro.org> - 2016-10-27 22:30 +0200
    Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 09:30 +0200
      Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 09:40 +0200
        Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 11:50 +0200
          Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 12:00 +0200
            Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 12:20 +0200
              Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 14:00 +0200
                Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into  dwmmc nodes Leo Yan <leo.yan@linaro.org> - 2016-10-28 14:40 +0200
                Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes John Stultz <john.stultz@linaro.org> - 2016-10-28 23:20 +0200
      Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc  nodes Jaehoon Chung <jh80.chung@samsung.com> - 2016-10-28 10:10 +0200

csiph-web