Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"
Date	2016-10-26 23:30 +0200
Message-ID	<swDVL-UP-25@gated-at.bofh.it> (permalink)
References	<suZe2-rP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Sven Eckelmann <sven@narfation.org>
Date: Sat, 22 Oct 2016 09:46:24 +0200

> The maximum MTU is defined via the slave devices of an batman-adv
> interface. Thus it is not possible to calculate the max_mtu during the
> creation of the batman-adv device when no slave devices are attached. Doing
> so would for example break non-fragmentation setups which then
> (incorrectly) allow an MTU of 1500 even when underlying device cannot
> transport 1500 bytes + batman-adv headers.
> 
> Checking the dynamically calculated max_mtu via the minimum of the slave
> devices MTU during .ndo_change_mtu is also used by the bridge interface.
> 
> Cc: Jarod Wilson <jarod@redhat.com>
> Fixes: b3e3893e1253 ("net: use core MTU range checking in misc drivers")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] batman-adv: Revert "use core MTU range checking in misc drivers" Sven Eckelmann <sven@narfation.org> - 2016-10-22 09:50 +0200
  Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc  drivers" Jarod Wilson <jarod@redhat.com> - 2016-10-23 03:10 +0200
    Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers" Sven Eckelmann <sven@narfation.org> - 2016-10-23 09:20 +0200
      Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc  drivers" Jarod Wilson <jarod@redhat.com> - 2016-10-24 03:50 +0200
  Re: [PATCH] batman-adv: Revert "use core MTU range checking in  misc drivers" David Miller <davem@davemloft.net> - 2016-10-26 23:30 +0200

csiph-web