Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

From	Jarod Wilson <jarod@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"
Date	2016-10-24 03:50 +0200
Message-ID	<svCyJ-LL-1@gated-at.bofh.it> (permalink)
References	<suZe2-rP-3@gated-at.bofh.it> <svfst-2ye-7@gated-at.bofh.it> <svley-6iz-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Oct 23, 2016 at 09:17:50AM +0200, Sven Eckelmann wrote:
> On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote:
> [...]
> > You're going to
> > need more than just this revert though, since batman-adv calls
> > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless
> > batadv_hardif_min_mtu() always returns something 1500 or less.
> 
> It does only returns 1500 or less at the moment.
> 
>     return min_t(int, min_mtu - batadv_max_header_len(), ETH_DATA_LEN);
> 
> > Actually,
> > looking at that, you could omit the mtu < 68 bit from
> > batadv_interface_change_mtu() too, since that'll already get done in the
> > core, but I have no clue what you need for max_mtu.
> 
> I would like to get this revert through net-next.git before anything else.

Looks like that should work fine then.

-- 
Jarod Wilson
jarod@redhat.com

Thread

[PATCH] batman-adv: Revert "use core MTU range checking in misc drivers" Sven Eckelmann <sven@narfation.org> - 2016-10-22 09:50 +0200
  Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc  drivers" Jarod Wilson <jarod@redhat.com> - 2016-10-23 03:10 +0200
    Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers" Sven Eckelmann <sven@narfation.org> - 2016-10-23 09:20 +0200
      Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc  drivers" Jarod Wilson <jarod@redhat.com> - 2016-10-24 03:50 +0200
  Re: [PATCH] batman-adv: Revert "use core MTU range checking in  misc drivers" David Miller <davem@davemloft.net> - 2016-10-26 23:30 +0200

csiph-web