[PATCH 4/4] serial: 8250_uniphier: avoid locking for FCR register write

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	[PATCH 4/4] serial: 8250_uniphier: avoid locking for FCR register write
Date	2016-10-24 10:10 +0200
Message-ID	<svIuu-4UV-13@gated-at.bofh.it> (permalink)
References	<svIkO-4BM-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The hardware book says, the FCR is combined with a register called
CHAR (it will trigger interrupt when a specific character is
received).  At first, I used lock/read/modify/write/unlock dance for
the FCR to not affect the upper bits, but the CHAR is actually never
used.  It should not hurt to always clear the CHAR and to handle the
FCR as a normal case.  It can save the costly locking.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Suggested-by: Denys Vlasenko <dvlasenk@redhat.com>
---

 drivers/tty/serial/8250/8250_uniphier.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
index 92e7bb7..746680e 100644
--- a/drivers/tty/serial/8250/8250_uniphier.c
+++ b/drivers/tty/serial/8250/8250_uniphier.c
@@ -101,7 +101,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
 static void uniphier_serial_out(struct uart_port *p, int offset, int value)
 {
 	unsigned int valshift = 0;
-	bool normal = false;
+	bool normal = true;
 
 	switch (offset) {
 	case UART_FCR:
@@ -114,9 +114,9 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
 		/* fall through */
 	case UART_MCR:
 		offset = UNIPHIER_UART_LCR_MCR;
+		normal = false;
 		break;
 	default:
-		normal = true;
 		offset <<= UNIPHIER_UART_REGSHIFT;
 		break;
 	}
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] serial: 8250_uniphier: some fixes and optimization Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-10-24 10:10 +0200
  [PATCH 3/4] serial: 8250_uniphier: hardcode regshift to avoid unneeded memory read Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-10-24 10:10 +0200
  [PATCH 4/4] serial: 8250_uniphier: avoid locking for FCR register write Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-10-24 10:10 +0200

csiph-web