Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505056

Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Oct 19, 2016 at 11:02:34PM +0900, Milo Kim wrote:
> The argument can be removed because the driver private data has it.
> 
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> ---
>  drivers/spi/spi-sun6i.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
> index 91235b2..c638f5d 100644
> --- a/drivers/spi/spi-sun6i.c
> +++ b/drivers/spi/spi-sun6i.c
> @@ -105,8 +105,9 @@ static inline void sun6i_spi_write(struct sun6i_spi *sspi, u32 reg, u32 value)
>  	writel(value, sspi->base_addr + reg);
>  }
>  
> -static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi, int len)
> +static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi)
>  {
> +	int len = sspi->fifo_depth;
>  	u32 reg, cnt;
>  	u8 byte;

I'm not so sure about this one. This function was initially to drain
any given number of bytes, which might be of interest at some point.

Removing that argument also remove that ability... Any particular
reason you want to change it?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Support H3 SPI controller Milo Kim <woogyom.kim@gmail.com> - 2016-10-19 18:20 +0200
  [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size Milo Kim <woogyom.kim@gmail.com> - 2016-10-19 18:20 +0200
    Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer  size Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-20 18:00 +0200
      Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer  size Milo Kim <woogyom.kim@gmail.com> - 2016-10-21 15:50 +0200
  [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Milo Kim <woogyom.kim@gmail.com> - 2016-10-19 18:30 +0200
    Re: [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Chen-Yu Tsai <wens@csie.org> - 2016-10-20 18:00 +0200
      Re: [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Milo Kim <woogyom.kim@gmail.com> - 2016-10-21 15:40 +0200
    Re: [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-20 18:00 +0200

csiph-web