Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505964

Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size

From Milo Kim <woogyom.kim@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size
Date 2016-10-21 15:50 +0200
Message-ID <suImR-6aO-13@gated-at.bofh.it> (permalink)
References <su1Bg-3zK-23@gated-at.bofh.it> <su1KW-3Hg-15@gated-at.bofh.it> <sunV7-161-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 10/21/2016 12:56 AM, Maxime Ripard wrote:
>> -static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi, int len)
>> > +static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi)
>> >  {
>> > +	int len = sspi->fifo_depth;
>> >  	u32 reg, cnt;
>> >  	u8 byte;
> I'm not so sure about this one. This function was initially to drain
> any given number of bytes, which might be of interest at some point.
>
> Removing that argument also remove that ability... Any particular
> reason you want to change it?

I just wanted to remove duplicate variable but I agree with you. Let me 
drop this in the next patch-set. Thanks for your comments.

Best regards,
Milo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Support H3 SPI controller Milo Kim <woogyom.kim@gmail.com> - 2016-10-19 18:20 +0200
  [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size Milo Kim <woogyom.kim@gmail.com> - 2016-10-19 18:20 +0200
    Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer  size Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-20 18:00 +0200
      Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer  size Milo Kim <woogyom.kim@gmail.com> - 2016-10-21 15:50 +0200
  [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Milo Kim <woogyom.kim@gmail.com> - 2016-10-19 18:30 +0200
    Re: [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Chen-Yu Tsai <wens@csie.org> - 2016-10-20 18:00 +0200
      Re: [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Milo Kim <woogyom.kim@gmail.com> - 2016-10-21 15:40 +0200
    Re: [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-20 18:00 +0200

csiph-web