Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1506241

Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts
Date 2016-10-21 21:20 +0200
Message-ID <suNwe-1sv-15@gated-at.bofh.it> (permalink)
References <suL1n-8bl-5@gated-at.bofh.it> <suL1o-8bl-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Oct 21, 2016 at 7:37 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> The interrupts can now be delivered as platform MSI interrupts on newer
> platforms. The code looks for a new OF and ACPI strings in order to enable
> the functionality.

> +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
> +static void hidma_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
> +{
> +       struct device *dev = msi_desc_to_dev(desc);
> +       struct hidma_dev *dmadev = dev_get_drvdata(dev);
> +
> +       if (!desc->platform.msi_index) {
> +               writel(msg->address_lo, dmadev->dev_evca + 0x118);
> +               writel(msg->address_hi, dmadev->dev_evca + 0x11C);
> +               writel(msg->data, dmadev->dev_evca + 0x120);
> +       }
> +}
> +#endif
> +
> +static void hidma_free_msis(struct hidma_dev *dmadev)
> +{
> +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN

Perhaps one #ifdef and two definitions of functions?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Sinan Kaya <okaya@codeaurora.org> - 2016-10-21 18:40 +0200
  Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-21 21:20 +0200
    Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for  interrupts Sinan Kaya <okaya@codeaurora.org> - 2016-10-24 05:00 +0200
      Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-24 09:40 +0200
        Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for  interrupts okaya@codeaurora.org - 2016-10-24 13:10 +0200

csiph-web