Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1506836
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts |
| Date | 2016-10-24 05:00 +0200 |
| Message-ID | <svDEu-1yA-5@gated-at.bofh.it> (permalink) |
| References | <suL1n-8bl-5@gated-at.bofh.it> <suL1o-8bl-33@gated-at.bofh.it> <suNwe-1sv-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/21/2016 12:11 PM, Andy Shevchenko wrote:
>> +static void hidma_free_msis(struct hidma_dev *dmadev)
>> > +{
>> > +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
> Perhaps one #ifdef and two definitions of functions?
I don't think it will make a difference. I'll have to move
#ifdef around the caller of hidma_free_msis instead which
I think is uglier.
The hidma_write_msi_msg function gets called only when
CONFIG_GENERIC_MSI_IRQ_DOMAIN is defined. If I don't put
this around the function definition, I get unused function
warning from the compiler. This is the reason why preprocessor
definition is outside of the function definition.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Sinan Kaya <okaya@codeaurora.org> - 2016-10-21 18:40 +0200
Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-21 21:20 +0200
Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Sinan Kaya <okaya@codeaurora.org> - 2016-10-24 05:00 +0200
Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-24 09:40 +0200
Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts okaya@codeaurora.org - 2016-10-24 13:10 +0200
csiph-web