Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1504271
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK |
| Date | 2016-10-19 21:30 +0200 |
| Message-ID | <su4IN-5Ai-19@gated-at.bofh.it> (permalink) |
| References | <su4z8-5wI-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Oct 20, 2016 at 01:11:08AM +0600, Alexander Kuleshov wrote:
> as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> arch/x86/entry/calling.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
> index 9a9e588..b493c6a 100644
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
>
> #define SIZEOF_PTREGS 21*8
>
> - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
> - addq $-(15*8+\addskip), %rsp
> + .macro ALLOC_PT_GPREGS_ON_STACK
> + addq $-(15*8), %rsp
> .endm
>
> .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
> --
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-10-19 21:20 +0200 Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Borislav Petkov <bp@alien8.de> - 2016-10-19 21:30 +0200 [tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK tip-bot for Alexander Kuleshov <tipbot@zytor.com> - 2016-10-20 11:10 +0200 [tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro tip-bot for Alexander Kuleshov <tipbot@zytor.com> - 2016-10-20 13:10 +0200
csiph-web