Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1504267 > unrolled thread
| Started by | Alexander Kuleshov <kuleshovmail@gmail.com> |
|---|---|
| First post | 2016-10-19 21:20 +0200 |
| Last post | 2016-10-20 13:10 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-10-19 21:20 +0200
Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Borislav Petkov <bp@alien8.de> - 2016-10-19 21:30 +0200
[tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK tip-bot for Alexander Kuleshov <tipbot@zytor.com> - 2016-10-20 11:10 +0200
[tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro tip-bot for Alexander Kuleshov <tipbot@zytor.com> - 2016-10-20 13:10 +0200
| From | Alexander Kuleshov <kuleshovmail@gmail.com> |
|---|---|
| Date | 2016-10-19 21:20 +0200 |
| Subject | [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK |
| Message-ID | <su4z8-5wI-23@gated-at.bofh.it> |
as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it. Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> --- arch/x86/entry/calling.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h index 9a9e588..b493c6a 100644 --- a/arch/x86/entry/calling.h +++ b/arch/x86/entry/calling.h @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with #define SIZEOF_PTREGS 21*8 - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0 - addq $-(15*8+\addskip), %rsp + .macro ALLOC_PT_GPREGS_ON_STACK + addq $-(15*8), %rsp .endm .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1 -- 2.8.0.rc3.1353.gea9bdc0
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-10-19 21:30 +0200 |
| Subject | Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK |
| Message-ID | <su4IN-5Ai-19@gated-at.bofh.it> |
| In reply to | #1504267 |
On Thu, Oct 20, 2016 at 01:11:08AM +0600, Alexander Kuleshov wrote:
> as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> arch/x86/entry/calling.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
> index 9a9e588..b493c6a 100644
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
>
> #define SIZEOF_PTREGS 21*8
>
> - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
> - addq $-(15*8+\addskip), %rsp
> + .macro ALLOC_PT_GPREGS_ON_STACK
> + addq $-(15*8), %rsp
> .endm
>
> .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
> --
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Alexander Kuleshov <tipbot@zytor.com> |
|---|---|
| Date | 2016-10-20 11:10 +0200 |
| Subject | [tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK |
| Message-ID | <suhwm-5w9-15@gated-at.bofh.it> |
| In reply to | #1504267 |
Commit-ID: ac679bf247cf044a5be6ca7d380307540284dd45 Gitweb: http://git.kernel.org/tip/ac679bf247cf044a5be6ca7d380307540284dd45 Author: Alexander Kuleshov <kuleshovmail@gmail.com> AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Thu, 20 Oct 2016 10:57:37 +0200 x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK The ALLOC_PT_GPREGS_ON_STACK macro has an optional addskip parameter, which is not used by any usage site. Remove it. Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> Reviewed-by: Borislav Petkov <bp@alien8.de> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Andy Lutomirski <luto@kernel.org> Link: http://lkml.kernel.org/r/20161019191108.2230-1-kuleshovmail@gmail.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/x86/entry/calling.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h index 9a9e588..b493c6a 100644 --- a/arch/x86/entry/calling.h +++ b/arch/x86/entry/calling.h @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with #define SIZEOF_PTREGS 21*8 - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0 - addq $-(15*8+\addskip), %rsp + .macro ALLOC_PT_GPREGS_ON_STACK + addq $-(15*8), %rsp .endm .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Alexander Kuleshov <tipbot@zytor.com> |
|---|---|
| Date | 2016-10-20 13:10 +0200 |
| Subject | [tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro |
| Message-ID | <sujou-6KH-15@gated-at.bofh.it> |
| In reply to | #1504267 |
Commit-ID: 59df2268311795ee7161776248d5288ee0841d41 Gitweb: http://git.kernel.org/tip/59df2268311795ee7161776248d5288ee0841d41 Author: Alexander Kuleshov <kuleshovmail@gmail.com> AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Thu, 20 Oct 2016 08:42:36 +0200 x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> Reviewed-by: Borislav Petkov <bp@suse.de> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20161019191108.2230-1-kuleshovmail@gmail.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/entry/calling.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h index 9a9e588..b493c6a 100644 --- a/arch/x86/entry/calling.h +++ b/arch/x86/entry/calling.h @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with #define SIZEOF_PTREGS 21*8 - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0 - addq $-(15*8+\addskip), %rsp + .macro ALLOC_PT_GPREGS_ON_STACK + addq $-(15*8), %rsp .endm .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web