Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1502663
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) |
| Date | 2016-10-18 04:40 +0200 |
| Message-ID | <ststP-47S-9@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <sqIv7-1FC-5@gated-at.bofh.it> <sr3pT-666-15@gated-at.bofh.it> <sschr-2Xb-3@gated-at.bofh.it> <stfdg-3r0-29@gated-at.bofh.it> <stfGh-3Br-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Balbir Singh <bsingharora@gmail.com> writes: > On 17/10/16 23:24, Michael Ellerman wrote: >> That happened because we haven't yet called set_cpu_numa_node() for the non-boot >> cpus, because that happens in smp_prepare_cpus(), and >> workqueue_init_early() is called much earlier than that. >> >> This doesn't trigger on x86 because it does set_cpu_numa_node() in >> setup_per_cpu_areas(), which is called prior to workqueue_init_early(). >> >> We can (should) probably do the same on powerpc, I'll look at that >> tomorrow. But other arches may have a similar problem, and at the very >> least we need to document that workqueue_init_early() relies on >> cpu_to_node() working. > > Don't we do the setup cpu->node mapings in initmem_init()? > Ideally we have setup_arch->intmem_init->numa_setup_cpu That sets up numa_cpu_lookup_table, which is a powerpc only data structure. But it doesn't setup the percpu numa_node variables, used by cpu_to_node(), because percpu areas are not setup yet. cheers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Tejun Heo <tj@kernel.org> - 2016-10-14 17:10 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Balbir Singh <bsingharora@gmail.com> - 2016-10-15 03:30 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Michael Ellerman <mpe@ellerman.id.au> - 2016-10-15 11:50 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Tejun Heo <tj@kernel.org> - 2016-10-17 20:20 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Michael Ellerman <mpe@ellerman.id.au> - 2016-10-17 14:30 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Balbir Singh <bsingharora@gmail.com> - 2016-10-17 15:00 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Michael Ellerman <mpe@ellerman.id.au> - 2016-10-18 04:40 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Tejun Heo <tj@kernel.org> - 2016-10-17 20:20 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Tejun Heo <tj@kernel.org> - 2016-10-17 21:40 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Tejun Heo <tj@kernel.org> - 2016-10-18 21:10 +0200
Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Michael Ellerman <mpe@ellerman.id.au> - 2016-10-19 17:00 +0200
[PATCH wq/for-4.10] workqueue: move wq_numa_init() to workqueue_init() Tejun Heo <tj@kernel.org> - 2016-10-19 18:20 +0200
csiph-web