Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot)

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot)
Date	2016-10-10 15:10 +0200
Message-ID	<sqIv7-1FC-5@gated-at.bofh.it> (permalink)
References	<shKFP-2IM-5@gated-at.bofh.it> <shKFQ-2IM-33@gated-at.bofh.it> <sirB7-5py-13@gated-at.bofh.it> <sqGMF-zG-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Michael.

On Mon, Oct 10, 2016 at 09:22:55PM +1100, Michael Ellerman wrote:
> This patch seems to be causing one of my Power8 boxes not to boot.
> 
> Specifically commit 3347fa092821 ("workqueue: make workqueue available
> early during boot") in linux-next.
> 
> If I revert this on top of next-20161005 then the machine boots again.
> 
> I've attached the oops below. It looks like the cfs_rq of p->se is NULL?

Hah, weird that it's arch dependent, or maybe it's just different
config options.  Most likely, it's caused by workqueue_init() call
being moved too early.  Can you please try the following patch and see
whether the problem goes away?

Thanks.

diff --git a/init/main.c b/init/main.c
index 5c4fd68..fe4fa47 100644
--- a/init/main.c
+++ b/init/main.c
@@ -1013,7 +1013,7 @@ static noinline void __init kernel_init_freeable(void)
 
 	smp_prepare_cpus(setup_max_cpus);
 
-	workqueue_init();
+	//workqueue_init();
 
 	do_pre_smp_initcalls();
 	lockup_detector_init();
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index ad0cd43..400f5e2 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -5585,3 +5585,4 @@ int __init workqueue_init(void)
 
 	return 0;
 }
+early_initcall(workqueue_init);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue  available early during boot) Tejun Heo <tj@kernel.org> - 2016-10-10 15:10 +0200
  Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue  available early during boot) Tejun Heo <tj@kernel.org> - 2016-10-10 15:20 +0200
  Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Michael Ellerman <mpe@ellerman.id.au> - 2016-10-11 13:30 +0200
    Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue  available early during boot) Balbir Singh <bsingharora@gmail.com> - 2016-10-11 14:30 +0200

csiph-web