Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503306

Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument type

Show all headers | View raw

Hi Ryan,

On 18.10.2016 20:03, Ryan Swan wrote:
> sparse produced
> warning: incorrect type in argument 2 (different address spaces)
> expected void const volatile [noderef] <asn:2>*src
> got struct slic_stats *stats
> 
> casting argument 2 to what is expected by memcpy_fromio() fixed this
> 
> Signed-off-by: Ryan Swan <ryan@ryanswan.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 2802b90..7c6feb1 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
>  		if (stats->rcv_drops > old->rcv_drops)
>  			adapter->rcv_drops += (stats->rcv_drops -
>  					       old->rcv_drops);
> -		memcpy_fromio(old, stats, sizeof(*stats));
> +		memcpy_fromio(old, (void __iomem *)stats, sizeof(*stats));
>  		break;
>  	}
>  	case SLIC_UPR_RLSR:
> 

The issue here is the use of memcpy_fromio() while it actually is not io but dma 
memory that we copy from.

Regards,
Lino

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument type Ryan Swan <ryan@ryanswan.com> - 2016-10-18 20:10 +0200
  Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument  type Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-10-18 21:30 +0200
  Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument  type Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-19 17:00 +0200

csiph-web