[PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument type

From	Ryan Swan <ryan@ryanswan.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument type
Date	2016-10-18 20:10 +0200
Message-ID	<stGZP-5pH-25@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

sparse produced
warning: incorrect type in argument 2 (different address spaces)
expected void const volatile [noderef] <asn:2>*src
got struct slic_stats *stats

casting argument 2 to what is expected by memcpy_fromio() fixed this

Signed-off-by: Ryan Swan <ryan@ryanswan.com>
---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 2802b90..7c6feb1 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
 		if (stats->rcv_drops > old->rcv_drops)
 			adapter->rcv_drops += (stats->rcv_drops -
 					       old->rcv_drops);
-		memcpy_fromio(old, stats, sizeof(*stats));
+		memcpy_fromio(old, (void __iomem *)stats, sizeof(*stats));
 		break;
 	}
 	case SLIC_UPR_RLSR:
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument type Ryan Swan <ryan@ryanswan.com> - 2016-10-18 20:10 +0200
  Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument  type Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-10-18 21:30 +0200
  Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument  type Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-19 17:00 +0200

csiph-web