Re: [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()
Date	2016-10-15 23:50 +0200
Message-ID	<ssF05-4WP-9@gated-at.bofh.it> (permalink)
References	<srOyt-49a-5@gated-at.bofh.it> <sshTQ-6Ez-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sat, 15 Oct 2016 00:01:20 +0300

> vmxnet3_set_mc() checks new_table_pa returned by dma_map_single()
> with dma_mapping_error(), but even there it assumes zero is invalid pa
> (it assumes dma_mapping_error(...,0) returns true if new_table is NULL).
> 
> The patch adds an explicit variable to track status of new_table_pa.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> v2: use "bool" and "true"/"false" for boolean variables.
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in  vmxnet3_set_mc() David Miller <davem@davemloft.net> - 2016-10-13 15:50 +0200
  [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-10-14 23:10 +0200
    Re: [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in  vmxnet3_set_mc() David Miller <davem@davemloft.net> - 2016-10-15 23:50 +0200

csiph-web