Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500275

Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()
Date 2016-10-13 15:50 +0200
Message-ID <srOyt-49a-5@gated-at.bofh.it> (permalink)
References <spQ1H-1aX-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri,  7 Oct 2016 22:53:43 -0400

> vmxnet3_set_mc() still assumes zero is invalid pa:
>   it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails;
>   it calls dma_unmap_single() iff new_table_pa is not zero.
> 
> The patch adds an explicit variable to track status of new_table_pa.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Please use "bool" and "true"/"false" for boolean variables.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-10-08 05:00 +0200
  Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in  vmxnet3_set_mc() David Miller <davem@davemloft.net> - 2016-10-13 15:50 +0200
    [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-10-14 23:10 +0200
      Re: [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in  vmxnet3_set_mc() David Miller <davem@davemloft.net> - 2016-10-15 23:50 +0200

csiph-web