Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500506
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue |
| Date | 2016-10-13 21:20 +0200 |
| Message-ID | <srTHP-7Il-5@gated-at.bofh.it> (permalink) |
| References | <srQJX-5Jj-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 2016-10-13 at 09:05 -0700, Nadim Almas wrote:
> Fixed coding style issue
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
> drivers/staging/ks7010/eap_packet.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
> index df7f760..90432ff 100644
> --- a/drivers/staging/ks7010/eap_packet.h
> +++ b/drivers/staging/ks7010/eap_packet.h
> @@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
> * encrypt the Key field; 64-bit NTP timestamp MAY be used here
> */
> unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
> - unsigned char key_iv[IEEE8021X_KEY_IV_LEN]; /* cryptographically random number */
> + unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
> + /* cryptographically random number */
> unsigned char key_index; /*
> * key flag in the most significant bit:
> * 0 = broadcast (default key),
> - * 1 = unicast (key mapping key); key index is in the
> + * 1 = unicast (key mapping key); key
> + * index is in the
> * 7 least significant bits
>
Might be better as
unsigned char key_index; /* Key flag:
* Most significant bit:
* 0: broadcast (default key)
* 1: unicast (key mapping key)
* key index is the value of
* the 7 least significant bits
*/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-13 18:10 +0200
Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-13 18:30 +0200
Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-13 21:30 +0200
Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue Joe Perches <joe@perches.com> - 2016-10-13 21:20 +0200
csiph-web