Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500512

Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

Show all headers | View raw

Note, the mailing lists reject html email, please fix up your client.

On Fri, Oct 14, 2016 at 12:34:30AM +0530, Nadim Almas wrote:
> But i have seen in some place where comments are below the line
> like in
> here from "drivers/staging/ks7010/eap_packet.h"
>  line number 100
> 
> 
>  struct wpa_eapol_key {
> unsigned char type;
> unsigned short key_info;
> unsigned short key_length;
> unsigned char replay_counter[WPA_REPLAY_COUNTER_LEN];
> unsigned char key_nonce[WPA_NONCE_LEN];
> unsigned char key_iv[16];
> unsigned char key_rsc[8];
> unsigned char key_id[8]; /* Reserved in IEEE 802.11i/RSN */
> unsigned char key_mic[16];
> unsigned short key_data_length;
> /* followed by key_data_length bytes of key_data */
> } __packed;

Read that comment, it makes sense to be there, right?  Because it
describes the field after the one above it.

Thanks for proving my point :)

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit  coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-13 18:10 +0200
  Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit  coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-13 18:30 +0200
    Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit  coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-13 21:30 +0200
  Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line  limit coding style issue Joe Perches <joe@perches.com> - 2016-10-13 21:20 +0200

csiph-web