Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498759

Re: [PATCH v3] xenbus: advertize control feature flags

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 10/10/16 12:13, Paul Durrant wrote:
> The Xen docs specify several flags which a guest can set to advertize
> which values of the xenstore control/shutdown key it will recognize.
> This patch adds code to write all the relevant feature-flag keys.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Juergen Gross <jgross@suse.com>

Hmm, I'd prefer node[] allocated on the stack over dynamic allocation.

What about something like the following? It will at least issue build
warnings in case the size is too small, will use less memory and less
coding.


Juergen

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] xenbus: advertize control feature flags Paul Durrant <paul.durrant@citrix.com> - 2016-10-10 12:40 +0200
  Re: [PATCH v3] xenbus: advertize control feature flags Juergen Gross <jgross@suse.com> - 2016-10-11 13:00 +0200
    Re: [PATCH v3] xenbus: advertize control feature flags David Vrabel <david.vrabel@citrix.com> - 2016-10-11 13:30 +0200

csiph-web