Re: [PATCH v3] xenbus: advertize control feature flags

From	David Vrabel <david.vrabel@citrix.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] xenbus: advertize control feature flags
Date	2016-10-11 13:30 +0200
Message-ID	<sr3pU-666-17@gated-at.bofh.it> (permalink)
References	<sqG9X-7J-3@gated-at.bofh.it> <sr2WR-5FD-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/10/16 11:53, Juergen Gross wrote:
> On 10/10/16 12:13, Paul Durrant wrote:
>> The Xen docs specify several flags which a guest can set to advertize
>> which values of the xenstore control/shutdown key it will recognize.
>> This patch adds code to write all the relevant feature-flag keys.
>>
>> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: David Vrabel <david.vrabel@citrix.com>
>> Cc: Juergen Gross <jgross@suse.com>
> 
> Hmm, I'd prefer node[] allocated on the stack over dynamic allocation.
> 
> What about something like the following? It will at least issue build
> warnings in case the size is too small, will use less memory and less
> coding.

You still want snprintf() just to be sure.  You can add a Reviewed-by
David Vrabel <david.vrabel@citrix.com> if you make this change.

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] xenbus: advertize control feature flags Paul Durrant <paul.durrant@citrix.com> - 2016-10-10 12:40 +0200
  Re: [PATCH v3] xenbus: advertize control feature flags Juergen Gross <jgross@suse.com> - 2016-10-11 13:00 +0200
    Re: [PATCH v3] xenbus: advertize control feature flags David Vrabel <david.vrabel@citrix.com> - 2016-10-11 13:30 +0200

csiph-web