Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1498668
| From | LABBE Corentin <clabbe.montjoie@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linux-sunxi] [PATCH 2/5] pwm: Add Allwinner A31 SoC support |
| Date | 2016-10-11 11:10 +0200 |
| Message-ID | <sr1ep-4LC-7@gated-at.bofh.it> (permalink) |
| References | <sr1ep-4LC-9@gated-at.bofh.it> <sr1ep-4LC-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello
I have a minor comment below
On Tue, Oct 11, 2016 at 02:34:46PM +0800, Icenowy Zheng wrote:
> This adds a generic PWM framework driver for the PWM controller found
> on Allwinner A31 and A31s SoCs.
>
> The PWM controller is different with other Allwinner SoCs, with a
> control register per channel (in other SoCs the control register is
> shared), and each channel are allocated 16 bytes of address (but only 8
> bytes are used.)
>
> In order to use the driver for all channels, device nodes should be
> created per channel.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-sun6i.c | 323 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 334 insertions(+)
> create mode 100644 drivers/pwm/pwm-sun6i.c
>
> +
> +static int sun6i_pwm_probe(struct platform_device *pdev)
> +{
> + struct sun6i_pwm_chip *pwm;
> + struct resource *res;
> + u32 val;
> + int ret;
> + const struct of_device_id *match;
> +
> + match = of_match_device(sun6i_pwm_dt_ids, &pdev->dev);
match is not used after.
Regards
Corentin Labbe
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [linux-sunxi] [PATCH 2/5] pwm: Add Allwinner A31 SoC support LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-10-11 11:10 +0200
csiph-web