Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498668 > unrolled thread

Re: [linux-sunxi] [PATCH 2/5] pwm: Add Allwinner A31 SoC support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [linux-sunxi] [PATCH 2/5] pwm: Add Allwinner A31 SoC support LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-10-11 11:10 +0200

#1498668 — Re: [linux-sunxi] [PATCH 2/5] pwm: Add Allwinner A31 SoC support

Hello

I have a minor comment below

On Tue, Oct 11, 2016 at 02:34:46PM +0800, Icenowy Zheng wrote:
> This adds a generic PWM framework driver for the PWM controller found
> on Allwinner A31 and A31s SoCs.
> 
> The PWM controller is different with other Allwinner SoCs, with a
> control register per channel (in other SoCs the control register is
> shared), and each channel are allocated 16 bytes of address (but only 8
> bytes are used.)
> 
> In order to use the driver for all channels, device nodes should be
> created per channel.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  drivers/pwm/Kconfig     |  10 ++
>  drivers/pwm/Makefile    |   1 +
>  drivers/pwm/pwm-sun6i.c | 323 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 334 insertions(+)
>  create mode 100644 drivers/pwm/pwm-sun6i.c
> 
> +
> +static int sun6i_pwm_probe(struct platform_device *pdev)
> +{
> +	struct sun6i_pwm_chip *pwm;
> +	struct resource *res;
> +	u32 val;
> +	int ret;
> +	const struct of_device_id *match;
> +
> +	match = of_match_device(sun6i_pwm_dt_ids, &pdev->dev);

match is not used after.

Regards

Corentin Labbe

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web