[tip:perf/urgent] tools lib traceevent: Fix kbuffer_read_at_offset()

From	tip-bot for Namhyung Kim <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:perf/urgent] tools lib traceevent: Fix kbuffer_read_at_offset()
Date	2016-10-07 00:50 +0200
Message-ID	<sppEd-7qB-19@gated-at.bofh.it> (permalink)
References	<snpyF-71K-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  a130347973c408c0e0017a52c74cbc3226c1f0ef
Gitweb:     http://git.kernel.org/tip/a130347973c408c0e0017a52c74cbc3226c1f0ef
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Sat, 1 Oct 2016 19:17:00 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 5 Oct 2016 11:36:22 -0300

tools lib traceevent: Fix kbuffer_read_at_offset()

When it's called with an offset less than or equal to the first event,
it'll return a garbage value since the data is not initialized.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20161001101700.29146-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/kbuffer-parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c
index 3bcada3..65984f1 100644
--- a/tools/lib/traceevent/kbuffer-parse.c
+++ b/tools/lib/traceevent/kbuffer-parse.c
@@ -622,6 +622,7 @@ void *kbuffer_read_at_offset(struct kbuffer *kbuf, int offset,
 
 	/* Reset the buffer */
 	kbuffer_load_subbuffer(kbuf, kbuf->subbuffer);
+	data = kbuffer_read_event(kbuf, ts);
 
 	while (kbuf->curr < offset) {
 		data = kbuffer_next_event(kbuf, ts);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Namhyung Kim <namhyung@kernel.org> - 2016-10-01 12:20 +0200
  Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 13:40 +0200
  Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Steven Rostedt <rostedt@goodmis.org> - 2016-10-05 15:30 +0200
    Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Namhyung Kim <namhyung@kernel.org> - 2016-10-07 06:20 +0200
      Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Steven Rostedt <rostedt@goodmis.org> - 2016-10-07 16:10 +0200
  [tip:perf/urgent] tools lib traceevent: Fix  kbuffer_read_at_offset() tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-10-07 00:50 +0200

csiph-web