Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1495824

Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset()

Show all headers | View raw

Em Sat, Oct 01, 2016 at 07:17:00PM +0900, Namhyung Kim escreveu:
> When it's called with an offset less than or equal to the first event,
> it'll return a garbage value since the data is not initialized.

Steven, Ack?

- Arnaldo
 
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/lib/traceevent/kbuffer-parse.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c
> index 3bcada3ae05a..65984f1c2974 100644
> --- a/tools/lib/traceevent/kbuffer-parse.c
> +++ b/tools/lib/traceevent/kbuffer-parse.c
> @@ -622,6 +622,7 @@ void *kbuffer_read_at_offset(struct kbuffer *kbuf, int offset,
>  
>  	/* Reset the buffer */
>  	kbuffer_load_subbuffer(kbuf, kbuf->subbuffer);
> +	data = kbuffer_read_event(kbuf, ts);
>  
>  	while (kbuf->curr < offset) {
>  		data = kbuffer_next_event(kbuf, ts);
> -- 
> 2.10.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Namhyung Kim <namhyung@kernel.org> - 2016-10-01 12:20 +0200
  Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 13:40 +0200
  Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Steven Rostedt <rostedt@goodmis.org> - 2016-10-05 15:30 +0200
    Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Namhyung Kim <namhyung@kernel.org> - 2016-10-07 06:20 +0200
      Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Steven Rostedt <rostedt@goodmis.org> - 2016-10-07 16:10 +0200
  [tip:perf/urgent] tools lib traceevent: Fix  kbuffer_read_at_offset() tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-10-07 00:50 +0200

csiph-web