Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs()

From	Alexander Gordeev <agordeev@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs()
Date	2016-10-06 10:30 +0200
Message-ID	<spcdX-60e-21@gated-at.bofh.it> (permalink)
References	<sn62Z-2jW-7@gated-at.bofh.it> <sn62Z-2jW-33@gated-at.bofh.it> <sp2eC-7H9-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 06, 2016 at 12:47:26AM +0300, Sagi Grimberg wrote:
> 
> >@@ -1908,33 +1909,36 @@ static void blk_mq_realloc_hw_ctxs(struct blk_mq_tag_set *set,
> > 		if (node == NUMA_NO_NODE)
> > 			node = set->numa_node;
> >
> >-		hctxs[i] = kzalloc_node(sizeof(struct blk_mq_hw_ctx),
> >-					GFP_KERNEL, node);
> >-		if (!hctxs[i])
> >+		hctx = kzalloc_node(sizeof(*hctx), GFP_KERNEL, node);
> >+		if (!hctx)
> > 			break;
> >
> >-		if (blk_mq_init_hctx(q, set, hctxs[i], i, node)) {
> >-			kfree(hctxs[i]);
> >-			hctxs[i] = NULL;
> >+		if (blk_mq_init_hctx(q, set, hctx, i, node)) {
> >+			kfree(hctx);
> > 			break;
> > 		}
> >-		blk_mq_hctx_kobj_init(hctxs[i]);
> >+
> >+		blk_mq_hctx_kobj_init(hctx);
> >+		hctxs[i] = hctx;
> > 	}
> > 	for (j = i; j < q->nr_hw_queues; j++) {
> >-		struct blk_mq_hw_ctx *hctx = hctxs[j];
> >+		hctx = hctxs[i];
> 
> Didn't you mean hctx[j]?

Surely, I did.
Thanks!

Thread

[PATCH v2 0/8] blk-mq: Minor cleanups Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
  [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
    Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Sagi Grimberg <sagi@grimberg.me> - 2016-10-05 23:50 +0200
      Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Alexander Gordeev <agordeev@redhat.com> - 2016-10-06 10:30 +0200
        Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Sagi Grimberg <sagi@grimberg.me> - 2016-10-06 12:20 +0200
      [PATCH v3 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Alexander Gordeev <agordeev@redhat.com> - 2016-10-09 23:40 +0200
  [PATCH v2 7/8] blk-mq: Pair blk_mq_hctx_kobj_init() with blk_mq_hctx_kobj_put() Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
    [PATCH v3 7/8] blk-mq: Pair blk_mq_hctx_kobj_init() with  blk_mq_hctx_kobj_put() Alexander Gordeev <agordeev@redhat.com> - 2016-10-09 23:40 +0200
  [PATCH v2 5/8] blk-mq: Cleanup blk_mq_hw_ctx::cpumask (de-)allocation Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
  [PATCH v2 2/8] blk-mq: Remove a redundant assignment Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
    Re: [PATCH v2 2/8] blk-mq: Remove a redundant assignment Sagi Grimberg <sagi@grimberg.me> - 2016-10-05 23:40 +0200
  [PATCH v2 4/8] blk-mq: Cleanup a loop exit condition Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200

csiph-web