Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494109

[PATCH v2 4/8] blk-mq: Cleanup a loop exit condition

Show all headers | View raw

CC: linux-block@vger.kernel.org
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
---
 block/blk-mq.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index e3e9b23..eed6e348 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1607,16 +1607,13 @@ static void blk_mq_exit_hctx(struct request_queue *q,
 }
 
 static void blk_mq_exit_hw_queues(struct request_queue *q,
-		struct blk_mq_tag_set *set, int nr_queue)
+		struct blk_mq_tag_set *set)
 {
 	struct blk_mq_hw_ctx *hctx;
 	unsigned int i;
 
-	queue_for_each_hw_ctx(q, hctx, i) {
-		if (i == nr_queue)
-			break;
+	queue_for_each_hw_ctx(q, hctx, i)
 		blk_mq_exit_hctx(q, set, hctx, i);
-	}
 }
 
 static void blk_mq_free_hw_queues(struct request_queue *q,
@@ -2039,7 +2036,7 @@ void blk_mq_free_queue(struct request_queue *q)
 
 	blk_mq_del_queue_tag_set(q);
 
-	blk_mq_exit_hw_queues(q, set, set->nr_hw_queues);
+	blk_mq_exit_hw_queues(q, set);
 	blk_mq_free_hw_queues(q, set);
 }
 
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/8] blk-mq: Minor cleanups Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
  [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
    Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Sagi Grimberg <sagi@grimberg.me> - 2016-10-05 23:50 +0200
      Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Alexander Gordeev <agordeev@redhat.com> - 2016-10-06 10:30 +0200
        Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Sagi Grimberg <sagi@grimberg.me> - 2016-10-06 12:20 +0200
      [PATCH v3 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Alexander Gordeev <agordeev@redhat.com> - 2016-10-09 23:40 +0200
  [PATCH v2 7/8] blk-mq: Pair blk_mq_hctx_kobj_init() with blk_mq_hctx_kobj_put() Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
    [PATCH v3 7/8] blk-mq: Pair blk_mq_hctx_kobj_init() with  blk_mq_hctx_kobj_put() Alexander Gordeev <agordeev@redhat.com> - 2016-10-09 23:40 +0200
  [PATCH v2 5/8] blk-mq: Cleanup blk_mq_hw_ctx::cpumask (de-)allocation Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
  [PATCH v2 2/8] blk-mq: Remove a redundant assignment Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200
    Re: [PATCH v2 2/8] blk-mq: Remove a redundant assignment Sagi Grimberg <sagi@grimberg.me> - 2016-10-05 23:40 +0200
  [PATCH v2 4/8] blk-mq: Cleanup a loop exit condition Alexander Gordeev <agordeev@redhat.com> - 2016-09-30 15:30 +0200

csiph-web