Re: [PATCH 6/6] mISDN: remove unused function

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] mISDN: remove unused function
Date	2016-10-04 17:00 +0200
Message-ID	<sozmh-4b2-7@gated-at.bofh.it> (permalink)
References	<skNHc-5m9-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Saturday, September 24, 2016 1:28:02 PM CEST Baoyou Xie wrote:
> diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
> index f6ab6027..2519510 100644
> --- a/drivers/isdn/mISDN/layer2.c
> +++ b/drivers/isdn/mISDN/layer2.c
> @@ -459,15 +459,6 @@ IsDISC(u_char *data)
>         return (data[0] & 0xef) == DISC;
>  }
>  
> -inline int
> -IsRR(u_char *data, struct layer2 *l2)
> -{
> -       if (test_bit(FLG_MOD128, &l2->flag))
> -               return data[0] == RR;
> -       else
> -               return (data[0] & 0xf) == 1;
> -}
> -
>  static inline int
>  IsSFrame(u_char *data, struct layer2 *l2)
>  {
> -- 
> 

This is not wrong, but it might be nicer to just
make this one as 'static inline' as well like the other
ones for consistency.

Note that static inline functions don't cause a warning
when they are unused.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] mISDN: remove unused function Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-24 07:30 +0200
  Re: [PATCH 6/6] mISDN: remove unused function Arnd Bergmann <arnd@arndb.de> - 2016-10-04 17:00 +0200

csiph-web