Re: [PATCH 6/6] mISDN: remove unused function

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!enother.net!enother.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] mISDN: remove unused function
Date	Tue, 04 Oct 2016 17:00:01 +0200
Message-ID	<sozmh-4b2-7@gated-at.bofh.it> (permalink)
References	<skNHc-5m9-11@gated-at.bofh.it>
User-Agent	KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:OICCF7OyiA8rueQu3c3/V+7Iweu6VIVkuHhs4ID9mchQq2cJAqa jkZG3MRoTJRocMjAGsdsvEt3zwZfinVOaxXTbpKm54Pxp0WdZHpWlb4mQF9RD1LOfU2gX9S e6THpf6UTn7vZndZo2tTLBPJxG0lxfVtXASMe+EtxpaRjs/qbkxAz5E4tjvOE8sjRVqGxXY TOVAaIDXSDUu8abCVoLEw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:ah9NyOY8Wk8=:933j9yTYZYDc6/NkWBXoq4 x73dJmpAt4z5OywYLFN7E7IRVC30DBm+MgT1KuCoGMfOvEFYf2d8EODDaXC8Gx0Xt43zXk0+N HDi6j7tfWl/v6VJ0iOFvbsT1GgnJuRKZ5MqnlZCyOdxmnwE+qOgNzOCQnNZBPOle3kQFIGRnm Sr1f+5//c8jZnvthkiPgYyCd6JqH3W9Hp0oT87sBdqApGM5YG9pLO7shEdV68FBnh3Q4NFhBv U1s5OWnvtNVWobKmICtV1vQE/DcnPELr0MHTFQozBA1nM6CFa7EKe4Pkfojp5sjnSAzlFkbbz RLLVCiR/YQCwRoBmFdu/wQDzoNSBGrZNrhAPXXysIfpxiBHZLauZX9zTA0qdA2/Byhb4cQgAm 8Lel4r1gVD46k4HJ7pgFQ2mWoOFahxSQBAs7mGjb+OX+3gC+EGdbywq1jR+IKdphV2gEydL/b j15Q+tOt/CSUb3suVFcbO3ExyvW4aZIJ0H95WkOfaFxNJZ3uCBm+SxzOO5lC1xRDmMUzD+z0K zdHnYUqG9WaSrP7PFUU8Hyo+f82I0pawyzYHQiZu7zBzgbH8w5jRQMiFYtgO2ROiVneq8njd/ A3YwYK2edqCLMDPHXMA4lvzzNlN/PikzO/BRT8AMZ91YB6Kk/UJBJixq7uz5bQcPFQRwXBAu3 cztb/pJL3A3gdmGuo1v9MLvpWTiRVOr61L4U69a3/jSQgKxpk2aosWMSbyQAb9swJPImwhvUv 3WsbCyPl/1ZcMZCp
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	isdn@linux-pingi.de, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
X-Original-Date	Sat, 24 Sep 2016 10:42:14 +0200
X-Original-Message-ID	<6975809.FmUs8oxeay@wuerfel>
X-Original-References	<1474694882-25427-1-git-send-email-baoyou.xie@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1495460

Show key headers only | View raw

On Saturday, September 24, 2016 1:28:02 PM CEST Baoyou Xie wrote:
> diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
> index f6ab6027..2519510 100644
> --- a/drivers/isdn/mISDN/layer2.c
> +++ b/drivers/isdn/mISDN/layer2.c
> @@ -459,15 +459,6 @@ IsDISC(u_char *data)
>         return (data[0] & 0xef) == DISC;
>  }
>  
> -inline int
> -IsRR(u_char *data, struct layer2 *l2)
> -{
> -       if (test_bit(FLG_MOD128, &l2->flag))
> -               return data[0] == RR;
> -       else
> -               return (data[0] & 0xf) == 1;
> -}
> -
>  static inline int
>  IsSFrame(u_char *data, struct layer2 *l2)
>  {
> -- 
> 

This is not wrong, but it might be nicer to just
make this one as 'static inline' as well like the other
ones for consistency.

Note that static inline functions don't cause a warning
when they are unused.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] mISDN: remove unused function Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-24 07:30 +0200
  Re: [PATCH 6/6] mISDN: remove unused function Arnd Bergmann <arnd@arndb.de> - 2016-10-04 17:00 +0200

csiph-web