Re: [PATCH] ixgbe: mark symbols static where possible

From	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ixgbe: mark symbols static where possible
Date	2016-09-26 00:30 +0200
Message-ID	<slq5Q-3YZ-39@gated-at.bofh.it> (permalink)
References	<slaNr-2Yy-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no
> previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes]
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no
> previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes]
> 
> In fact, these two functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


This has been fixed and pushed upstream, why do you keep submitting this?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ixgbe: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-25 08:10 +0200
  Re: [PATCH] ixgbe: mark symbols static where possible Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-09-26 00:30 +0200

csiph-web