Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1490988
| From | Jeff Kirsher <jeffrey.t.kirsher@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static |
| Date | 2016-09-26 00:30 +0200 |
| Message-ID | <slq5P-3YZ-25@gated-at.bofh.it> (permalink) |
| References | <slaNs-2Yy-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This has been fixed as well, and there is already a patch.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-25 08:10 +0200
Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-09-26 00:30 +0200
Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static Arnd Bergmann <arnd@arndb.de> - 2016-09-26 01:20 +0200
csiph-web