Re: [PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0
Date	2016-09-22 13:10 +0200
Message-ID	<ska39-5ym-73@gated-at.bofh.it> (permalink)
References	<sjv9D-4MD-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 20, 2016 at 10:25:40AM -0500, Dave Gerlach wrote:
> Currently omap-rng checks the return value of pm_runtime_get_sync and
> reports failure if anything is returned, however it should be checking
> if ret < 0 as pm_runtime_get_sync return 0 on success but also can return
> 1 if the device was already active which is not a failure case. Only
> values < 0 are actual failures.
> 
> Fixes: 61dc0a446e5d ("hwrng: omap - Fix assumption that runtime_get_sync will always succeed")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0 Dave Gerlach <d-gerlach@ti.com> - 2016-09-20 17:30 +0200
  Re: [PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns <  0 Herbert Xu <herbert@gondor.apana.org.au> - 2016-09-22 13:10 +0200

csiph-web