Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1488778
| Path | csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Herbert Xu <herbert@gondor.apana.org.au> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0 |
| Date | Thu, 22 Sep 2016 13:10:03 +0200 |
| Message-ID | <ska39-5ym-73@gated-at.bofh.it> (permalink) |
| References | <sjv9D-4MD-11@gated-at.bofh.it> |
| X-Original-To | Dave Gerlach <d-gerlach@ti.com> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 15 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Deepak Saxena <dsaxena@plexity.net>, Matt Mackall <mpm@selenic.com>, Nishanth Menon <nm@ti.com>, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org |
| X-Original-Date | Thu, 22 Sep 2016 18:46:24 +0800 |
| X-Original-Message-ID | <20160922104624.GK5884@gondor.apana.org.au> |
| X-Original-References | <20160920152540.3004-1-d-gerlach@ti.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1488778 |
Show key headers only | View raw
On Tue, Sep 20, 2016 at 10:25:40AM -0500, Dave Gerlach wrote:
> Currently omap-rng checks the return value of pm_runtime_get_sync and
> reports failure if anything is returned, however it should be checking
> if ret < 0 as pm_runtime_get_sync return 0 on success but also can return
> 1 if the device was already active which is not a failure case. Only
> values < 0 are actual failures.
>
> Fixes: 61dc0a446e5d ("hwrng: omap - Fix assumption that runtime_get_sync will always succeed")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0 Dave Gerlach <d-gerlach@ti.com> - 2016-09-20 17:30 +0200 Re: [PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0 Herbert Xu <herbert@gondor.apana.org.au> - 2016-09-22 13:10 +0200
csiph-web