Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

From	Rafał Miłecki <zajec5@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags
Date	2016-09-20 07:20 +0200
Message-ID	<sjlDk-7aN-3@gated-at.bofh.it> (permalink)
References	<rSqAG-51z-29@gated-at.bofh.it> <rSqKl-54R-3@gated-at.bofh.it> <s77mp-pk-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 17 August 2016 at 13:34, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 8 July 2016 at 01:08, Jon Mason <jon.mason@broadcom.com> wrote:
>>         mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >>
>>                 BGMAC_DS_MM_SHIFT;
>> -       if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0)
>> +       if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0)
>>                 bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT);
>> -       if (ci->id == BCMA_CHIP_ID_BCM47162 && mode == 2)
>> +       if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2)
>>                 bcma_chipco_chipctl_maskset(&bgmac->core->bus->drv_cc, 1, ~0,
>>                                             BGMAC_CHIPCTL_1_RXC_DLL_BYPASS);
>
> Jon, it looks to me you translated two following conditions:
> ci->id != BCMA_CHIP_ID_BCM47162
> and
> ci->id == BCMA_CHIP_ID_BCM47162
> into the same flag check:
> bgmac->feature_flags & BGMAC_FEAT_CLKCTLST
>
> I don't think it's intentional, is it? Do you have a moment to fix this?

Ping

-- 
Rafał

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags Rafał Miłecki <zajec5@gmail.com> - 2016-09-20 07:20 +0200
  Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags Jon Mason <jon.mason@broadcom.com> - 2016-09-20 16:00 +0200

csiph-web