Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487061

Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic

Show all headers | View raw

Le 20/09/2016 à 04:28, Aneesh Kumar K.V a écrit :
> christophe leroy <christophe.leroy@c-s.fr> writes:
>
>> Le 19/09/2016 à 07:50, Aneesh Kumar K.V a écrit :
>>>
>>> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>>> +#else
>>>> +static void hugepd_free(struct mmu_gather *tlb, void *hugepte)
>>>> +{
>>>> +	BUG();
>>>> +}
>>>> +
>>>>  #endif
>>>
>>>
>>> I was expecting that BUG will get removed in the next patch. But I don't
>>> see it in the next patch. Considering
>>>
>>> @@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *tlb, hugepd_t *hpdp, int pdshif
>>>         for (i = 0; i < num_hugepd; i++, hpdp++)
>>>                 hpdp->pd = 0;
>>>
>>> -#ifdef CONFIG_PPC_FSL_BOOK3E
>>> -	hugepd_free(tlb, hugepte);
>>> -#else
>>> -	pgtable_free_tlb(tlb, hugepte, pdshift - shift);
>>> -#endif
>>> +	if (shift >= pdshift)
>>> +		hugepd_free(tlb, hugepte);
>>> +	else
>>> +		pgtable_free_tlb(tlb, hugepte, pdshift - shift);
>>>  }
>>>
>>> What is that I am missing ?
>>>
>>
>> Previously, call to hugepd_free() was compiled only when #ifdef
>> CONFIG_PPC_FSL_BOOK3E
>> Now, it is compiled at all time, but it should never be called if not
>> CONFIG_PPC_FSL_BOOK3E because we always have shift < pdshift in that case.
>> Then the function needs to be defined anyway but should never be called.
>> Should I just define it static inline {} ?
>>
>
> For 8M with 4K mode, we have shift >= pdshift right ?
>

Yes, thats the reason why in the following patch we get. That way we get 
a real hugepd_free() also for the 8xx.

@@ -366,7 +373,7 @@ int alloc_bootmem_huge_page(struct hstate *hstate)
  }
  #endif

-#ifdef CONFIG_PPC_FSL_BOOK3E
+#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_8xx)
  #define HUGEPD_FREELIST_SIZE \
  	((PAGE_SIZE - sizeof(struct hugepd_freelist)) / sizeof(pte_t))



Christophe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] powerpc: implementation of huge pages for 8xx Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-16 09:50 +0200
  [PATCH v2 1/3] powerpc: port 64 bits pgtable_cache to 32 bits Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-16 09:50 +0200
    Re: [PATCH v2 1/3] powerpc: port 64 bits pgtable_cache to 32 bits "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-19 07:30 +0200
      Re: [PATCH v2 1/3] powerpc: port 64 bits pgtable_cache to 32 bits christophe leroy <christophe.leroy@c-s.fr> - 2016-09-19 20:50 +0200
  [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-16 09:50 +0200
    Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-19 07:50 +0200
      Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic christophe leroy <christophe.leroy@c-s.fr> - 2016-09-19 20:40 +0200
        Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-20 04:50 +0200
      Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-21 08:20 +0200
    Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-19 08:00 +0200
      Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic christophe leroy <christophe.leroy@c-s.fr> - 2016-09-19 20:40 +0200
        Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-20 04:30 +0200
          Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-20 07:30 +0200

csiph-web