[PATCH] drm/ast: free correct pointer in astfb_create() error paths

From	Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/ast: free correct pointer in astfb_create() error paths
Date	2016-09-19 09:20 +0200
Message-ID	<sj11T-2o5-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In the err_free_vram and err_release_fbi error paths in astfb_create(), we
attempt to free afbdev->sysram. The only jumps to these error paths occur
before we assign afbdev->sysram = sysram. Free sysram instead.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

---

Found by Coverity Scan. Compile tested only.
---
 drivers/gpu/drm/ast/ast_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index c017a93..0fef8ea 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -254,7 +254,7 @@ static int astfb_create(struct drm_fb_helper *helper,
 err_release_fbi:
 	drm_fb_helper_release_fbi(helper);
 err_free_vram:
-	vfree(afbdev->sysram);
+	vfree(sysram);
 	return ret;
 }
 
-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/ast: free correct pointer in astfb_create() error paths Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-09-19 09:20 +0200
  [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-09-20 04:00 +0200
    Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create()  error paths Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-09-20 05:00 +0200

csiph-web