Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

From	Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths
Date	2016-09-20 05:00 +0200
Message-ID	<sjjrP-5Ci-9@gated-at.bofh.it> (permalink)
References	<sj11T-2o5-7@gated-at.bofh.it> <sjivL-4Vq-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/09/16 11:56, Andrew Donnellan wrote:
> In the err_free_vram and err_release_fbi error paths in astfb_create(), we
> attempt to free afbdev->sysram. The only jumps to these error paths occur
> before we assign afbdev->sysram = sysram. Free sysram instead.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
> ---
>
> Found by Coverity Scan. Compile tested only.
>
> Resending as it looks like this didn't hit dri-devel.

It did show up after all :)

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/ast: free correct pointer in astfb_create() error paths Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-09-19 09:20 +0200
  [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-09-20 04:00 +0200
    Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create()  error paths Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-09-20 05:00 +0200

csiph-web