Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1486152
| From | "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic |
| Date | 2016-09-19 08:00 +0200 |
| Message-ID | <siZMu-1sT-7@gated-at.bofh.it> (permalink) |
| References | <shW4h-1Eu-7@gated-at.bofh.it> <shW4h-1Eu-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> +#else
> +static void hugepd_free(struct mmu_gather *tlb, void *hugepte)
> +{
> + BUG();
> +}
> +
> #endif
I was expecting that BUG will get removed in the next patch. But I don't
see it in the next patch. Considering
@@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *tlb, hugepd_t *hpdp, int pdshif
for (i = 0; i < num_hugepd; i++, hpdp++)
hpdp->pd = 0;
-#ifdef CONFIG_PPC_FSL_BOOK3E
- hugepd_free(tlb, hugepte);
-#else
- pgtable_free_tlb(tlb, hugepte, pdshift - shift);
-#endif
+ if (shift >= pdshift)
+ hugepd_free(tlb, hugepte);
+ else
+ pgtable_free_tlb(tlb, hugepte, pdshift - shift);
}
What is that I am missing ?
-aneesh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/3] powerpc: implementation of huge pages for 8xx Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-16 09:50 +0200
[PATCH v2 1/3] powerpc: port 64 bits pgtable_cache to 32 bits Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-16 09:50 +0200
Re: [PATCH v2 1/3] powerpc: port 64 bits pgtable_cache to 32 bits "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-19 07:30 +0200
Re: [PATCH v2 1/3] powerpc: port 64 bits pgtable_cache to 32 bits christophe leroy <christophe.leroy@c-s.fr> - 2016-09-19 20:50 +0200
[PATCH v2 2/3] powerpc: get hugetlbpage handling more generic Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-16 09:50 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-19 07:50 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic christophe leroy <christophe.leroy@c-s.fr> - 2016-09-19 20:40 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-20 04:50 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-21 08:20 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-19 08:00 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic christophe leroy <christophe.leroy@c-s.fr> - 2016-09-19 20:40 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-20 04:30 +0200
Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-20 07:30 +0200
csiph-web