Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483131

Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error

Show all headers | View raw

On Wed, 14 Sep 2016, Arnd Bergmann wrote:
> Building tps65217 as a loadable module (as done in allmodconfig)
> now fails after we started calling irq_set_parent():
> 
>   ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
> 
> The two obvious workarounds are either to force the driver
> to be built-in, or to make that symbol exported to modules.
> 
> As it's not clear to me if either of them would be acceptable,
> I'm sending both of them here, please comment on which one
> you want to have, or whether the driver should handle this
> differently and not call irq_set_parent() at all.

The question is why it needs to call that. But if it's justified, then I'm
not opposed to export it.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [RFC] irqchip or mfd/tps65217: fix link error Arnd Bergmann <arnd@arndb.de> - 2016-09-14 10:50 +0200
  Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Thomas Gleixner <tglx@linutronix.de> - 2016-09-14 11:40 +0200
    Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Arnd Bergmann <arnd@arndb.de> - 2016-09-14 16:00 +0200
      Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Marcin Niestroj <m.niestroj@grinn-global.com> - 2016-09-14 17:40 +0200

csiph-web