Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1483131
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Thomas Gleixner <tglx@linutronix.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error |
| Date | Wed, 14 Sep 2016 11:40:01 +0200 |
| Message-ID | <shePD-7Az-27@gated-at.bofh.it> (permalink) |
| References | <she3f-734-5@gated-at.bofh.it> |
| User-Agent | Alpine 2.20 (DEB 67 2015-01-07) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Lee Jones <lee.jones@linaro.org>, "Andrew F. Davis" <afd@ti.com>, Marc Zyngier <marc.zyngier@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, linux-kernel@vger.kernel.org |
| X-Original-Date | Wed, 14 Sep 2016 11:31:17 +0200 (CEST) |
| X-Original-Message-ID | <alpine.DEB.2.20.1609141129440.6233@nanos> |
| X-Original-References | <20160914084202.1032264-1-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1483131 |
Show key headers only | View raw
On Wed, 14 Sep 2016, Arnd Bergmann wrote: > Building tps65217 as a loadable module (as done in allmodconfig) > now fails after we started calling irq_set_parent(): > > ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined! > > The two obvious workarounds are either to force the driver > to be built-in, or to make that symbol exported to modules. > > As it's not clear to me if either of them would be acceptable, > I'm sending both of them here, please comment on which one > you want to have, or whether the driver should handle this > differently and not call irq_set_parent() at all. The question is why it needs to call that. But if it's justified, then I'm not opposed to export it. Thanks, tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] [RFC] irqchip or mfd/tps65217: fix link error Arnd Bergmann <arnd@arndb.de> - 2016-09-14 10:50 +0200
Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Thomas Gleixner <tglx@linutronix.de> - 2016-09-14 11:40 +0200
Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Arnd Bergmann <arnd@arndb.de> - 2016-09-14 16:00 +0200
Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Marcin Niestroj <m.niestroj@grinn-global.com> - 2016-09-14 17:40 +0200
csiph-web