Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482389

Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
Date 2016-09-13 13:50 +0200
Message-ID <sgUnU-1gb-13@gated-at.bofh.it> (permalink)
References <sfpvP-wL-1@gated-at.bofh.it> <sgzMt-3XR-15@gated-at.bofh.it> <sgNcK-4Tl-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 13, 2016 at 6:04 AM, Phil Reid <preid@electromag.com.au> wrote:
> On 12/09/2016 21:40, Linus Walleij wrote:
>>
>> On Fri, Sep 9, 2016 at 10:31 AM, Colin King <colin.king@canonical.com>
>> wrote:
>>
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> ret is not initialized so it contains garbage.  Ensure garbage
>>> is not returned in the case that pdata && pdata->teardown is false
>>> by initializing ret to 0.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>>
>> Patch applied.
>
> G'day Linus,
>
>
> I believe this does the same as Arnd Bergmanns patch from 26 Aug.
> [PATCH 1/5] gpio: pca954x: fix undefined error code from remove
>
> IMO Colin's is the cleaner solution.
> Arnd's could be removed.

OK you're right. I reverted Arnd's patch.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-12 15:50 +0200
  Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning  garbage Phil Reid <preid@electromag.com.au> - 2016-09-13 06:10 +0200
    Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 13:50 +0200
    Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Arnd Bergmann <arnd@arndb.de> - 2016-09-13 14:40 +0200
      Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning  garbage Colin Ian King <colin.king@canonical.com> - 2016-09-13 14:50 +0200
      Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 14:50 +0200

csiph-web