Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
Date	2016-09-13 14:50 +0200
Message-ID	<sgVjX-1TH-3@gated-at.bofh.it> (permalink)
References	<sfpvP-wL-1@gated-at.bofh.it> <sgzMt-3XR-15@gated-at.bofh.it> <sgNcK-4Tl-13@gated-at.bofh.it> <sgVai-1PB-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 13, 2016 at 2:31 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> Please try to avoid adding initializations in the local variable
> declaration, they just hide otherwise useful warnings when
> you get a function that actually does something incorrect
> in some code paths.

Agreed, sorry for my ignorance :(

I duly corrected the git and reverted the other patch instead of yours.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-12 15:50 +0200
  Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning  garbage Phil Reid <preid@electromag.com.au> - 2016-09-13 06:10 +0200
    Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 13:50 +0200
    Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Arnd Bergmann <arnd@arndb.de> - 2016-09-13 14:40 +0200
      Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning  garbage Colin Ian King <colin.king@canonical.com> - 2016-09-13 14:50 +0200
      Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 14:50 +0200

csiph-web