Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480510

Re: [PATCH] fs/dcache: resched/chill only if we make no progress

Show all headers | View raw

On Thu, 8 Sep 2016, Sebastian Andrzej Siewior wrote:
> +		if (parent == dentry) {
> +			/* the task with the highest priority won't schedule */
> +			r = cond_resched();
> +			if (!r && (rt_task(current) || dl_task(current)))

That's wrong because a non RT task will just spin until its time slice is
up. Wasted cycles for nothing.

Ideally we make spinning conditional on 

    !on_cpu(dentry->lock->owner)

That would avoid going to sleep if the owner runs on another cpu. We have
no mechanism for that, but I think it'd be worth to think about one.

> +				cpu_chill();
> +		} else
> +			dentry = parent;

Missing braces

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] fs/dcache: resched/chill only if we make no progress Thomas Gleixner <tglx@linutronix.de> - 2016-09-10 08:20 +0200
  Re: [PATCH] fs/dcache: resched/chill only if we make no progress Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-09-14 19:20 +0200

csiph-web