Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477288

Re: ACPI-video: Fine-tuning for several function implementations

Show all headers | View raw

On Tue, Sep 6, 2016 at 5:28 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> I'd prefer this to be combined into fewer patches
>> that each will address several issues of one type,
>
> I understand your concern a bit in principle.
>
>
>> ie. put all label renames into one patch,
>
> Are any of my update suggestions controversial here?

Well, the label renames have a little value in general IMO, but that
depends on a particular case.

Anyway, if there's something I don't like in particular, I'll let you know.

>> all size determination improvements into another one and so on.
>
> I am unsure about the acceptance for the selected software change opportunities.
> So I chose a very specific patch granularity intentionally.
>
> I tend to provide some change ideas for each affected function
> implementation individually. I imagine that this way should support
> the recombination of update steps to some degree already, shouldn't it?

However, it's a pain to review 20 patches if you could review 4 instead.

Please take the reviewers' time into consideration too.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/21] ACPI-video: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 18:50 +0200
  [PATCH 01/21] ACPI-video: Use kmalloc_array() in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 18:50 +0200
  [PATCH 02/21] ACPI-video: Return directly after a failed device query SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 18:50 +0200
  [PATCH 08/21] ACPI-video: Improve a size determination in  acpi_video_bus_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:00 +0200
  [PATCH 07/21] ACPI-video: Rename jump labels in acpi_video_bus_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:00 +0200
  [PATCH 11/21] ACPI-video: Rename jump labels in  acpi_video_bus_add_notify_handler() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:00 +0200
  [PATCH 14/21] ACPI-video: Improve a size determination in  acpi_video_device_enumerate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 15/21] ACPI-video: Delete an unnecessary initialisation in  acpi_video_device_enumerate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 12/21] ACPI-video: Delete unnecessary if statement in  acpi_video_switch_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 18/21] ACPI-video: Rename jump labels in  acpi_video_init_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 13/21] ACPI-video: Improve a jump target in  acpi_video_switch_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 09/21] ACPI-video: Rename jump labels in acpi_video_register() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 16/21] ACPI-video: Rename jump labels in  acpi_video_device_enumerate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 19/21] ACPI-video: Rename a jump label in  acpi_video_device_lcd_query_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 21/21] ACPI-video: Improve a size determination in  acpi_video_bus_get_one_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 10/21] ACPI-video: Return directly after a failed  input_allocate_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 17/21] ACPI-video: Delete an unnecessary initialisation in  acpi_video_init_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 20/21] ACPI-video: Improve a size determination in  acpi_video_dev_register_backlight() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 04/21] ACPI-video: Rename jump labels in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:30 +0200
  [PATCH 06/21] ACPI-video: Move four assignments in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:30 +0200
  [PATCH 05/21] ACPI-video: Delete an unnecessary initialisation in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:30 +0200
  [PATCH 03/21] ACPI-video: Delete an error message for a failed  kzalloc() call SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:40 +0200
  Re: [PATCH 00/21] ACPI-video: Fine-tuning for several function implementations "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-05 23:50 +0200
    Re: ACPI-video: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-06 05:30 +0200
      Re: ACPI-video: Fine-tuning for several function implementations "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-06 13:30 +0200
        Re: ACPI-video: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-06 16:20 +0200
          Re: ACPI-video: Fine-tuning for several function implementations "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-06 23:10 +0200
            Re: ACPI-video: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-07 08:50 +0200

csiph-web